fix: return empty list for VASP forward_common_files to prevent upload errors #1811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical issue where
dpgen autotest run
would fail withRuntimeError: cannot find upload file
when using VASP as the DFT calculator.Problem
When running
dpgen autotest run relax.json machine.json
with VASP configuration, users encountered:This error occurred because:
forward_common_files()
method returned["INCAR", "POTCAR"]
confs/ZrO2-m/relaxation/
) and symlinks them to task directoriesSolution
Modified
VASP.forward_common_files()
to return an empty list[]
instead of["INCAR", "POTCAR"]
. This change:[]
for similar reasonsmake_input_file()
andmake_potential_files()
methodsforward_files()
method which correctly returns task-specific filesTesting
forward_files()
still returns correct task-specific files:["INCAR", "POSCAR", "KPOINTS", "POTCAR"]
Fixes #1139.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.