[ci] Remove --runtime=nvidia from launch_container.sh #2953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyang16
reviewed
Nov 19, 2025
ethnzhng
force-pushed
the
ez/launch-fix
branch
from
29c2388 to
0523af7
Compare
ethnzhng
changed the title
xyang16
reviewed
Nov 19, 2025
Co-authored-by: Xin Yang <[email protected]>
xyang16
reviewed
Nov 19, 2025
| -e AWS_ACCESS_KEY_ID=$AWS_ACCESS_KEY_ID \ | ||
| -e AWS_SECRET_ACCESS_KEY=$AWS_SECRET_ACCESS_KEY \ | ||
| -e AWS_SESSION_TOKEN=$AWS_SESSION_TOKEN \ | ||
| $uid_mapping \ |
Contributor
There was a problem hiding this comment.
Just realized this docker run doesn't have --gpus, we can add in line 253.
--gpus=all \
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
--runtime=nvidiadocker run flag is being deprecated and doesn't work in all environments. It is not needed as long as the--gpusflag is set