Skip to content

Commit

Permalink
Merge branch 'amine' of https://github.com/dedis/d-voting into amine
Browse files Browse the repository at this point in the history
  • Loading branch information
mamine2207 committed Oct 24, 2022
2 parents 997498d + 2234396 commit 35c6820
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
9 changes: 9 additions & 0 deletions docs/minutes/week-4-frontend.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Date: 17/10/2022

Participants: Ahmed Elalamy, Ghita Tagemouati, Khadija Tagemouati, Noémien Kocher

## Updates & next things

- Ghita had a lot of issues with trying to launch the system since she refactored the codebase. We look at it a little bit. She’ll find a way to make it work. Besides that she began trying to implement Casbin. Noémien and Ghita quickly discuss the benefits and drawbacks of roles vs user based. Everything is going well and she’s continuing that way.
- Ahmed began to look at the amount of work he would have to do to add the hint field. Noémien thinks that he should start by doing all the work on the interface and then look at how to change in the backend and smart contract way later. Ahmed is going to do this and change the mocks as well to make it work.
- Khadija started translation and is looking among her friends for a german speaking person so that they can check if she’s doing correct work. Noémien says that she should actually focus more on the actual i18n implementation on the interface. She will do so next.
2 changes: 1 addition & 1 deletion services/dkg/pedersen/handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ func TestHandler_Start(t *testing.T) {
h := Handler{
startRes: &state{},
privKey: privKey,
status: &dkg.Status{},
status: &dkg.Status{},
}
start := types.NewStart(
[]mino.Address{fake.NewAddress(0)},
Expand Down
3 changes: 2 additions & 1 deletion services/dkg/pedersen/mod_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,8 @@ func TestPedersen_Setup(t *testing.T) {
},
context: serdecontext,
formFac: formFac,
status: &dkg.Status{},
status: &dkg.Status{},

}

// Wrong formID
Expand Down

0 comments on commit 35c6820

Please sign in to comment.