-
Notifications
You must be signed in to change notification settings - Fork 5
vpk0 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ethteck
commented
Aug 17, 2024
- Rust implementation
- Rust tests
- Python bindings
- Python tests
- C bindings
- C tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the vpk0 compression format to the crunch64 library. The implementation provides compression and decompression functionality through the external vpk0 crate.
Key changes:
- Added vpk0 module with compress/decompress functions
- Integrated vpk0 support into CLI and error handling
- Updated dependencies and documentation
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/src/vpk0.rs | New module implementing vpk0 compression/decompression wrapper functions |
| lib/src/lib.rs | Added vpk0 module export and new Vpk0 error variant |
| lib/Cargo.toml | Added vpk0 crate dependency |
| cli/src/main.rs | Integrated vpk0 into CLI compression type enum and handlers |
| c_bindings/include/crunch64/error.h | Added corresponding C error enum variant |
| CHANGELOG.md | Documented the new vpk0 format support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@copilot can you update cargo.lock and do the remaining todos along with whatever else you think should be changed? write down all the stuff you do that I didn't explicitly ask for that you think is grood. ok z ya |