fix: allow per-connection refresh lead time override via providerSpecificData.refreshLeadMs (closes #593)#605
Open
anuragg-saxenaa wants to merge 1 commit intodecolua:masterfrom
Conversation
…ificData.refreshLeadMs (closes decolua#593)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #593 requested the ability to manually configure the Provider Connection timeout renewal time, as the current hardcoded renewal interval was too short.
Fix
Modified
getRefreshLeadMs()inopen-sse/services/tokenRefresh.jsto accept an optional per-connection override viaproviderSpecificData.refreshLeadMs:The caller in
src/sse/services/tokenRefresh.js(checkAndRefreshToken) now passescreds.providerSpecificDataso per-connection overrides take effect.Usage
To set a custom renewal lead time for a connection, set
providerSpecificData.refreshLeadMs(in milliseconds) on the connection. For example, to extend the renewal lead to 30 minutes:If not set, defaults to the provider-specific defaults from
REFRESH_LEAD_MSor the globalTOKEN_EXPIRY_BUFFER_MS(5 minutes).Closes #593