feat(vm): remove disk attachement capacity available #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eofff
force-pushed
the
feat/vm/remove-disk-attachement-capacity-available-condition
branch
from
a54e04d to
08f2c5b
Compare
added 2 commits
January 15, 2025 15:39
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
eofff
force-pushed
the
feat/vm/remove-disk-attachement-capacity-available-condition
branch
from
08f2c5b to
6d1ee4b
Compare
Isteb4k
requested changes
Jan 22, 2025
| @@ -95,6 +97,20 @@ func (h *BlockDeviceHandler) Handle(ctx context.Context, s state.VirtualMachineS | |||
| return reconcile.Result{}, fmt.Errorf("unable to add block devices finalizers: %w", err) | |||
| } | |||
|
|
|||
| // Get number of connected block devices | |||
| // If it greater limit then set condition to false | |||
| cb. | ||
| Status(metav1.ConditionFalse). | ||
| Reason(vmcondition.ReasonBlockDeviceCapacityReached). | ||
| Message(fmt.Sprintf("Can not attach %d block devices (%d is maximum) to `VirtualMachine` %q", blockDeviceAttachedCount, common.VmBlockDeviceAttachedLimit, changed.Name)) |
| @@ -102,8 +101,7 @@ const ( | |||
| ReasonVirtualMachineClassTerminating Reason = "VirtualMachineClassTerminating" | |||
| ReasonVirtualMachineClassNotExists Reason = "VirtalMachineClassNotExists" | |||
|
|
|||
| ReasonBlockDeviceCapacityAvailable Reason = "BlockDeviceCapacityAvailable" | |||
| ReasonBlockDeviceCapacityReached Reason = "BlockDeviceCapacityReached" | |||
| ReasonBlockDeviceCapacityReached Reason = "BlockDeviceCapacityReached" | |||
There was a problem hiding this comment.
May be BlockDeviceLimitExceeded ?
There was a problem hiding this comment.
Describe what this reason means, when it occurs. It's important to add docs for new reasons/types here.
| @@ -57,6 +58,7 @@ func NewBlockDeviceHandler(cl client.Client, recorder eventrecord.EventRecorderL | |||
| type BlockDeviceHandler struct { | |||
| client client.Client | |||
| recorder eventrecord.EventRecorderLogger | |||
| service IBlockDeviceService | |||
There was a problem hiding this comment.
What kind of service?
Need to rename
|
|
||
| type EventRecorder = record.EventRecorder | ||
|
|
||
| type IBlockDeviceService interface { |
There was a problem hiding this comment.
Why not just BlockDeviceService ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
DiskAttachementCapacityAvailablecondition, move it's logic toBlockDevicesReadynew reason.Why do we need it, and what problem does it solve?
What is the expected result?
Checklist