fix(vd): move metadata sync to its own step #1776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardcoretime
requested review from
Isteb4k,
fl64 and
yaroslavborbat
as code owners
hardcoretime
force-pushed
the
fix/vd/move-metadata-sync-to-its-own-step
branch
from
565b2ce to
706035d
Compare
Isteb4k
requested changes
Dec 5, 2025
...virtualization-artifact/pkg/controller/vd/internal/source/step/add_original_metadata_step.go
Outdated
Show resolved
Hide resolved
...virtualization-artifact/pkg/controller/vd/internal/source/step/add_original_metadata_step.go
Outdated
Show resolved
Hide resolved
...virtualization-artifact/pkg/controller/vd/internal/source/step/add_original_metadata_step.go
Outdated
Show resolved
Hide resolved
...virtualization-artifact/pkg/controller/vd/internal/source/step/add_original_metadata_step.go
Outdated
Show resolved
Hide resolved
...virtualization-artifact/pkg/controller/vd/internal/source/step/add_original_metadata_step.go
Outdated
Show resolved
Hide resolved
...virtualization-artifact/pkg/controller/vd/internal/source/step/add_original_metadata_step.go
Outdated
Show resolved
Hide resolved
hardcoretime
force-pushed
the
fix/vd/move-metadata-sync-to-its-own-step
branch
from
706035d to
97a077c
Compare
hardcoretime
force-pushed
the
fix/vd/move-metadata-sync-to-its-own-step
branch
from
97a077c to
87ddff8
Compare
Isteb4k
requested changes
Dec 9, 2025
...virtualization-artifact/pkg/controller/vd/internal/source/step/add_original_metadata_step.go
Outdated
Show resolved
Hide resolved
...virtualization-artifact/pkg/controller/vd/internal/source/step/add_original_metadata_step.go
Outdated
Show resolved
Hide resolved
...virtualization-artifact/pkg/controller/vd/internal/source/step/add_original_metadata_step.go
Show resolved
Hide resolved
added 6 commits
December 9, 2025 14:46
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
hardcoretime
force-pushed
the
fix/vd/move-metadata-sync-to-its-own-step
branch
from
87ddff8 to
99fb091
Compare
Isteb4k
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we need it, and what problem does it solve?
Some issues, such as a revision error, can occur when virtual disk metadata is updated in the
CreatePVCFromVDSnapshotStep, and the original metadata can be lost. To prevent this, the updating block has been moved to its own step.What is the expected result?
The original virtual disk metadata syncs correctly when restored from a virtual disk snapshot.
Checklist
Changelog entries