Skip to content

fix(vm): cyclic reboot of VM in CE version #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eofff merged 1 commit into from
Dec 8, 2025
Merged

fix(vm): cyclic reboot of VM in CE version #1774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion images/virtualization-artifact/pkg/controller/vm/internal/sync_kvvm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,11 @@ func (h *SyncKvvmHandler) syncKVVM(ctx context.Context, s state.VirtualMachineSt
if err != nil {
return false, fmt.Errorf("detect changes on the stopped internal virtual machine: %w", err)
}
if hasVMChanges {
hasVMClassChanges, err := h.detectVMClassSpecChanges(ctx, s)
if err != nil {
return false, fmt.Errorf("detect changes on the stopped internal virtual machine: %w", err)
}
if hasVMChanges || hasVMClassChanges {
err := h.updateKVVM(ctx, s)
if err != nil {
return false, fmt.Errorf("update stopped internal virtual machine: %w", err)
Expand Down Expand Up @@ -571,6 +575,21 @@ func (h *SyncKvvmHandler) detectVMSpecChanges(ctx context.Context, s state.Virtu
return currentKvvm.Annotations[annotations.AnnVMLastAppliedSpec] != newKvvm.Annotations[annotations.AnnVMLastAppliedSpec], nil
}

// detectVMClassSpecChanges returns true and no error if specification has changes.
func (h *SyncKvvmHandler) detectVMClassSpecChanges(ctx context.Context, s state.VirtualMachineState) (bool, error) {
currentKvvm, err := s.KVVM(ctx)
if err != nil {
return false, err
}

newKvvm, err := MakeKVVMFromVMSpec(ctx, s)
if err != nil {
return false, err
}

return currentKvvm.Annotations[annotations.AnnVMClassLastAppliedSpec] != newKvvm.Annotations[annotations.AnnVMClassLastAppliedSpec], nil
}

// canApplyChanges returns true if changes can be applied right now.
//
// Wait if changes are disruptive, and approval mode is manual, and VM is still running.
Expand Down
Loading