fix(vmrestore): vmbda fail #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

danilrwx merged 5 commits into main from fix/vmrestore/vmbda-fail

Dec 8, 2025

+66 −63

Contributor

danilrwx commented Nov 26, 2025 •

edited

Loading

Description

Fix cycle set cgroups by done it once after all mounts.

Why do we need it, and what problem does it solve?

Solves the problem when cgroummanager.Set is called in the next reconcile and resets the permissions on the block hotplug file. Before the fix, the first cgroummanager.Set was called only for the current device, now it will be called after all mounts immediately for all devices.

Checklist

The code is covered by unit tests.
e2e tests passed.
Documentation updated according to the changes.
Changes were tested in the Kubernetes cluster manually.

github-actions bot assigned danilrwx

danilrwx force-pushed the fix/vmrestore/vmbda-fail branch 5 times, most recently from f181a56 to 4942937 Compare

November 27, 2025 11:49

danilrwx added delve/virt-handler and removed delve/virt-handler labels

danilrwx force-pushed the fix/vmrestore/vmbda-fail branch 2 times, most recently from 7b4d9ea to 0486e0c Compare

December 3, 2025 08:54

danilrwx changed the title ~~Fix/vmrestore/vmbda fail~~ fix(vmrestore): vmbda fail

danilrwx force-pushed the fix/vmrestore/vmbda-fail branch from 2ae90cd to 0486e0c Compare

December 3, 2025 11:45

danilrwx added this to the v1.3.0 milestone

danilrwx added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 4, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

danilrwx added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 4, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

danilrwx added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 4, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

danilrwx added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 4, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

danilrwx added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 4, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

danilrwx added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 5, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

danilrwx force-pushed the fix/vmrestore/vmbda-fail branch from 0486e0c to 9034b51 Compare

December 8, 2025 08:44

danilrwx marked this pull request as ready for review

December 8, 2025 08:44

danilrwx requested review from Isteb4k, fl64, nevermarine and universal-itengineer as code owners

December 8, 2025 08:44

danilrwx added 4 commits

December 8, 2025 10:46


          Revert "fix(e2e): temp diable vmbda in VMRestore (#1754)"

376baf2

This reverts commit c1e6c5f.

Signed-off-by: Daniil Antoshin <[email protected]>

f4b48a1

Signed-off-by: Daniil Antoshin <[email protected]>


          update kubevirt

f9c6a72

Signed-off-by: Daniil Antoshin <[email protected]>


          apply

07a68d2

Signed-off-by: Daniil Antoshin <[email protected]>

danilrwx force-pushed the fix/vmrestore/vmbda-fail branch from 12e03cd to 07a68d2 Compare

December 8, 2025 08:46

danilrwx added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 8, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.


          return proxy

64beb4e

Signed-off-by: Daniil Antoshin <[email protected]>

danilrwx requested a review from yaroslavborbat

December 8, 2025 11:38

yaroslavborbat approved these changes

View reviewed changes

danilrwx merged commit 77c555b into main

11 checks passed

danilrwx deleted the fix/vmrestore/vmbda-fail branch

December 8, 2025 11:39

deckhouse-BOaTswain removed the e2e/run label

danilrwx added a commit that referenced this pull request


          Revert "fix(vmrestore): vmbda fail (#1759)"

b8dcc20

This reverts commit 77c555b.

Signed-off-by: Daniil Antoshin <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yaroslavborbat yaroslavborbat approved these changes

universal-itengineer Awaiting requested review from universal-itengineer universal-itengineer is a code owner

nevermarine Awaiting requested review from nevermarine nevermarine is a code owner

fl64 Awaiting requested review from fl64 fl64 is a code owner

Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

Labels

None yet