fix(images): make importers work in tainted cluster #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Isteb4k merged 3 commits into main from fix/images/toleration-system-nodes-for-importer-pods

Dec 11, 2025

Member

diafour commented Nov 25, 2025 •

edited by Isteb4k

Loading

Description

Add toleration to run importers on nodes belong to NodeGroup/system.
Add toleration to CDI config for DV workload Pods (importers, uploaders, preps, etc.).
vd contoller: move InUse handler before Lifecycle handler. Lifecycle handler can see "attached to" vm in status and copy tolerations from it.

Why do we need it, and what problem does it solve?

It is not possible to create images and disks with datasource in cluster where all nodes have taints.

What is the expected result?

FOCUS=VirtualImageCreation task e2e:run runs on tainted cluster

Ran 1 of 183 Specs in 434.664 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 182 Skipped
PASS

Checklist

The code is covered by unit tests.
e2e tests passed.
Documentation updated according to the changes.
Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: images
type: fix
summary: Added the ability to use system nodes to create project and cluster images.

diafour added this to the v1.2.0 milestone

diafour requested review from Isteb4k and yaroslavborbat as code owners

November 25, 2025 17:22

github-actions bot assigned diafour

diafour marked this pull request as draft

November 26, 2025 07:21

Isteb4k modified the milestones: v1.2.0, v1.3.0

diafour requested review from LopatinDmitr and eofff

November 27, 2025 08:08

diafour marked this pull request as ready for review

November 27, 2025 08:09

diafour requested a review from fl64 as a code owner

November 27, 2025 08:09

eofff requested changes

View reviewed changes

images/virtualization-artifact/pkg/controller/vd/internal/source/http.go Outdated Show resolved Hide resolved

images/virtualization-artifact/pkg/controller/vd/internal/source/http.go Outdated Show resolved Hide resolved

diafour force-pushed the fix/images/toleration-system-nodes-for-importer-pods branch from ca47f3d to 2ab0e13 Compare

December 1, 2025 11:40

diafour added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 1, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

deckhouse-BOaTswain removed the e2e/run label

diafour added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 1, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

diafour force-pushed the fix/images/toleration-system-nodes-for-importer-pods branch from 2ab0e13 to ec01193 Compare

December 2, 2025 07:09

diafour added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 2, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

deckhouse-BOaTswain removed the e2e/run label

diafour added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 2, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

diafour added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 2, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

diafour added the e2e/run label

deckhouse-BOaTswain removed the e2e/run label

diafour added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 10, 2025

Workflow has started.
Follow the progress here: Workflow Run

diafour dismissed danilrwx’s stale review via

a116c28

December 10, 2025 11:46

diafour force-pushed the fix/images/toleration-system-nodes-for-importer-pods branch from 9bbfeb7 to a116c28 Compare

December 10, 2025 11:46

deckhouse-BOaTswain removed the e2e/run label

diafour added e2e/user/Isteb4k e2e/run labels

Contributor

deckhouse-BOaTswain commented Dec 10, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

diafour added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 10, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

diafour added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 10, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

diafour added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 10, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

deckhouse-BOaTswain removed the e2e/run label

Isteb4k approved these changes

View reviewed changes

diafour added 3 commits

December 11, 2025 13:53


          fix(images): make importers work in tainted cluster

03693a4

- Add toleration to run importers on nodes belong to NodeGroup/system.

Signed-off-by: Ivan Mikheykin <[email protected]>


          ++ simplify

f926171

Signed-off-by: Ivan Mikheykin <[email protected]>


          ++ liveMigrationPolicy PreferForced for more stable migration of mutu…

4b9568b

…ally exclusive VMs on clusters with 3 nodes

Signed-off-by: Ivan Mikheykin <[email protected]>

diafour force-pushed the fix/images/toleration-system-nodes-for-importer-pods branch from dbb097a to 4b9568b Compare

December 11, 2025 10:53

diafour requested review from danilrwx and eofff

December 11, 2025 10:54

eofff approved these changes

View reviewed changes

Isteb4k merged commit bb6ff22 into main

27 of 28 checks passed

Isteb4k deleted the fix/images/toleration-system-nodes-for-importer-pods branch

December 11, 2025 12:25

deckhouse-BOaTswain mentioned this pull request

Changelog v1.3.0 #1710

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

eofff eofff approved these changes

Isteb4k Isteb4k approved these changes

yaroslavborbat Awaiting requested review from yaroslavborbat yaroslavborbat is a code owner

LopatinDmitr Awaiting requested review from LopatinDmitr

fl64 Awaiting requested review from fl64 fl64 is a code owner

danilrwx Awaiting requested review from danilrwx

Labels

e2e/user/Isteb4k