Skip to content

API for BlockDeviceFilter #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

API for BlockDeviceFilter #143

wants to merge 34 commits into from

Conversation

asergunov
Copy link
Contributor

@asergunov asergunov commented Apr 21, 2025 •
edited
Loading

Description

Introducing BlockDeviceFilter object to hide devices from the user

Why do we need it, and what problem does it solve?

Hiding node block devices handling by other modules

What is the expected result?

Controller respects BlockDeviceFilter resources and hides devices from the user

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@asergunov
API added
645ed0a 
Signed-off-by: Anton Sergunov <[email protected]>
kneumoin
kneumoin reviewed Apr 21, 2025
View reviewed changes
asergunov added 13 commits April 21, 2025 17:56
@asergunov
Fixing by review comments
b6de083 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
Fixing by review comments
dbf6852 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
Update deepcopy generation
b173ea9 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
TODO added
3107a4e 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
Implementation. Tests are moved
bbc80a0 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
naming
1632cc8 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
Fix the empty device list bug
08777aa 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
More test cases
809438f 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
Cases with existing devices
4d372e7 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
Check other node devices are not touched by this one
8495514 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
filter tests are added
753d906 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
WIP
3b57f7c 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
Merge remote-tracking branch 'origin/main' into block-device-filter
fabff4d
@asergunov asergunov added the enhancement New feature or request label Apr 28, 2025
@asergunov asergunov self-assigned this Apr 28, 2025
@asergunov
Fix filter client
22114c1 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
Create selector only once
f1bcb99 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
test names
d3d8e49 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov asergunov requested review from kneumoin and astef April 28, 2025 10:46
@asergunov asergunov marked this pull request as ready for review April 28, 2025 10:52
kneumoin
kneumoin previously approved these changes Apr 29, 2025
View reviewed changes
@asergunov
cleanup
cecac01 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
Test formatting
3f08b07 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
naming
6002951 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
move clients to repository package
e06435e 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
styling
e7cff46 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov asergunov requested a review from kneumoin April 29, 2025 11:33
kneumoin
kneumoin previously approved these changes Apr 29, 2025
View reviewed changes
@asergunov asergunov marked this pull request as draft April 30, 2025 11:13
@asergunov
Move label keys to api
1b0fd7d 
Signed-off-by: Anton Sergunov <[email protected]>
asergunov and others added 8 commits May 16, 2025 12:35
@asergunov
Suite name
b5782eb 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
Remove x-kubernetes-embedded-resource flag
b98c3bf 
Signed-off-by: Anton Sergunov <[email protected]>
@duckhawk @asergunov
Fix source repo for build (#146)
e6e3a7e 
Signed-off-by: v.oleynikov <[email protected]>
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
fix cluster role
b3c1ed0 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
Update filtration
01a1175 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
Add partitioned mpath cases in test suite
111060c 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
BlockDeviceFilter reconciler
2459f75 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov
missing license added
4415970 
Signed-off-by: Anton Sergunov <[email protected]>
@asergunov asergunov force-pushed the block-device-filter branch 2 times, most recently from 3b78758 to 4415970 Compare May 30, 2025 13:15
@asergunov asergunov force-pushed the block-device-filter branch from 30a1952 to 2da8e04 Compare June 2, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kneumoin kneumoin kneumoin left review comments

@astef astef Awaiting requested review from astef

At least 1 approving review is required to merge this pull request.

Assignees

@asergunov asergunov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asergunov @kneumoin @duckhawk