Instant query optimization v2 #203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 5, 2025 14:54
# Conflicts: # pp/entrypoint/go_constants.h # pp/go/cppbridge/entrypoint.h # pp/go/storage/querier/series.go # pp/go/storage/querier/series_bench_test.go
vporoshok
reviewed
Nov 13, 2025
vporoshok
reviewed
Nov 13, 2025
vporoshok
reviewed
Nov 13, 2025
Collaborator
vporoshok
left a comment
vporoshok
left a comment
There was a problem hiding this comment.
Please improve imports grouping in IDE
| // samples, dsQueryResult := ds.InstantQuery(targetTimestamp, valueNotFoundTimestampValue, lssQueryResult.IDs()) | ||
| // require.Equal(t, cppbridge.DataStorageQueryStatusSuccess, dsQueryResult.Status) | ||
| // return querier.NewInstantSeriesSet(lssQueryResult, snapshot, valueNotFoundTimestampValue, samples) | ||
| //} |
Collaborator
There was a problem hiding this comment.
remove instead of comment
added 3 commits
November 13, 2025 14:37
# Conflicts: # pp/go/storage/storagetest/fixtures.go
cherep58
reviewed
Nov 14, 2025
pp/go/storage/querier/querier.go
Outdated
| } | ||
|
|
||
| samples, result := s.DataStorage().InstantQuery(q.maxt, valueNotFoundTimestampValue, lssQueryResult.IDs()) | ||
| instantSeries := make([]InstantSeries, lssQueryResult.Len()) |
Collaborator
There was a problem hiding this comment.
Repeatable pattern. Maybe create method NewInstantSeries(size int, defaultTimestamp int64)?
cherep58
approved these changes
Nov 14, 2025
| storagetest.MustAppendTimeSeriesToLSSAndDataStorage(lss, ds, timeSeries...) | ||
| } | ||
|
|
||
| func BenchmarkInstantSeriesSet(b *testing.B) { |
Collaborator
There was a problem hiding this comment.
I refactored this function, why you don't use my version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.