Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 0.28 - 9. Custom CSS applied only according scoped restrictions, adapt admin module menu and forms #258

Merged
merged 66 commits into from
Nov 28, 2023

Conversation

entantoencuanto
Copy link
Contributor

@entantoencuanto entantoencuanto commented Nov 22, 2023

[WIP]

This PR:

  • Adapts the modals used to create and edit constraints to decidim_modals introduced in 0.28
  • Recovers the custom css code applied by scopes defined by admins in awesome menu
  • Updates the icons used by the module to use existing declared ones or register new icons specific of the module
  • Refactors the secondary nav menu of the module to use the same conventions of Decidim 0.28

Pending: See #257

image (4)
image (3)
image (2)
image (1)
image

@entantoencuanto entantoencuanto mentioned this pull request Nov 22, 2023
20 tasks
@entantoencuanto entantoencuanto changed the base branch from main to redesign November 23, 2023 14:29
@Crashillo Crashillo linked an issue Nov 27, 2023 that may be closed by this pull request
4 tasks
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (redesign@5686e58). Click here to learn what that means.

Additional details and impacted files
@@             Coverage Diff             @@
##             redesign     #258   +/-   ##
===========================================
  Coverage            ?   92.45%           
===========================================
  Files               ?      119           
  Lines               ?     3353           
  Branches            ?        0           
===========================================
  Hits                ?     3100           
  Misses              ?      253           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@entantoencuanto entantoencuanto marked this pull request as ready for review November 28, 2023 19:32
@entantoencuanto entantoencuanto merged commit 252660a into redesign Nov 28, 2023
@entantoencuanto entantoencuanto deleted the redesign_admin-config branch November 28, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to 0.28 - Admin front updates
2 participants