Proposal for Survey protocol #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial version readme.md version 0.1 for proposed survey protocol. Still several sections to complete
Read me updated with messages for survey 0.1 protocol
Rewrote the tutorial section of the read me, added example messages
Change the response message to contain a response_type indicating if the survey response will contain data (answers) or a decline
Add survey_id to the request message
Update reference implementation information
Corrected link label
TheTechmage
approved these changes
Jun 10, 2024
|
Looks like the primary issue is that the |
Change title from Survey Protocol to Survey Add Jorge Flores as author
|
I've updated the |
TimoGlastra
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Nice, i like the addition of this protocol! And I also like the re-use of JSON Schema with JSON Schema Forms, makes the protocol a lot easier.
Maybe it is worth it to add a mention of the Question Answer protocol and how this is an advanced version of that protocol?
|
Thank you @TimoGlastra for your feedback, it should be JSON objects instead of strings, I will update the protocol |
|
Is there anything holding up approval of this PR? |
TelegramSam
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A protocol where a survey (JSON Forms) is sent by the requester to the responder. The responder then replies with the answers or declines the survey.