Skip to content

work in progress: arbitrary proposal types #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

work in progress: arbitrary proposal types #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/deployables/freeze-voting/FreezeVotingAzoriusV1.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ contract FreezeVotingAzoriusV1 is
function castFreezeVote(
IVotingTypes.VotingConfigVoteData[] calldata votingConfigsToUse_,
uint256 lightAccountIndex_
) public virtual override {
) external virtual override {
// Step 1: Resolve the actual voter (handles Light Account case)
address resolvedVoter = potentialLightAccountResolvedOwner(
msg.sender,
Expand Down
6 changes: 3 additions & 3 deletions contracts/deployables/freeze-voting/FreezeVotingStandaloneV1.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ contract FreezeVotingStandaloneV1 is
*/
function initialize2(
IVotingTypes.VotingConfig[] calldata votingConfigs_
) public virtual override reinitializer(2) {
) external virtual override reinitializer(2) {
FreezeVotingStandaloneStorage
storage $ = _getFreezeVotingStandaloneStorage();

Expand Down Expand Up @@ -260,7 +260,7 @@ contract FreezeVotingStandaloneV1 is
function castFreezeVote(
IVotingTypes.VotingConfigVoteData[] calldata votingConfigsToUse_,
uint256 lightAccountIndex_
) public virtual override {
) external virtual override {
// Check if already frozen
if (isFrozen()) revert AlreadyFrozen();

Expand Down Expand Up @@ -293,7 +293,7 @@ contract FreezeVotingStandaloneV1 is
function castUnfreezeVote(
IVotingTypes.VotingConfigVoteData[] calldata votingConfigsToUse_,
uint256 lightAccountIndex_
) public virtual override {
) external virtual override {
FreezeVotingStandaloneStorage
storage $ = _getFreezeVotingStandaloneStorage();

Expand Down
8 changes: 7 additions & 1 deletion contracts/deployables/modules/ModuleAzoriusV1.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,13 @@
proposal.executionPeriod = $.executionPeriod;

// Step 4: Initialize voting period in the strategy contract
$.strategy.initializeProposal($.totalProposalCount);
// For backward compatibility, use the first authorized voting type as default
// In the future, this should be passed as a parameter to submitProposal
address[] memory votingTypes = $.strategy.authorizedVotingTypes();
require(votingTypes.length > 0, "No authorized voting types");

Check warning on line 475 in contracts/deployables/modules/ModuleAzoriusV1.sol

View workflow job for this annotation

GitHub Actions / solhint 

GC: Use Custom Errors instead of require statements

// Use SimpleVotingType config by default (empty bytes for default basis)
$.strategy.initializeProposal($.totalProposalCount, votingTypes[0], "");

// Step 5: Emit event with full proposal details for indexing
emit ProposalCreated(
Expand Down
Loading
Loading