Skip to content

fix(workbook): use computed company values for people sources - #75

Open
rudycelekli wants to merge 1 commit into
debpalash:mainfrom
rudycelekli:fix/opengtm-people-source-values-20261010
Open

rudycelekli wants to merge 1 commit into
debpalash:mainfrom
rudycelekli:fix/opengtm-people-source-values-20261010

Conversation

@rudycelekli

Copy link
Copy Markdown
Contributor

What & why

A people-search source configured with from_column reads only the row's original data. A saved AI/enrichment result therefore contributes no company, or an obsolete imported value is searched instead. A failed computed cell can also leave its old raw snapshot eligible for searching.

Read the selected column through the existing row_execution_data helper so completed saved cells are used and failed computed snapshots are invalidated. Keep the existing source selection, company ordering and deduplication, query budget, feature flag, tenant scope and person persistence.

Type

  • Bug fix
  • New feature
  • New enrichment provider / source
  • Docs
  • Refactor / chore

Verification

Six native source-to-person-persistence regressions cover AI formula, enrichment and waterfall columns by stable ID and display name. The rows contain overlay-only company values, newer completed values over old raw data, an obsolete failed value and a case-variant duplicate. Tests mock the DDG search seam; real source dispatch, provider query/parsing, SQLite reads and canonical person persistence run.

Before: six failures, plus two passing unchanged controls for input columns and disabled sourcing. After: all 62 tests in the people-source and shared cell-scope suites pass. Full unchanged canonical CI passed all four jobs on the signed head: SQLite (2,098 passed; 134 skipped; 3 deselected), PostgreSQL (18 passed), frontend lint/tests/build (63 tests) and browser regressions (3 passed).

Checklist

  • Commits are signed off (git commit -s) per the DCO
  • Backend tests pass — frozen canonical SQLite and PostgreSQL CI
  • Monorepo lint and build pass (bun run lint && bun run build) — canonical CI
  • I did not add scraping of paywalled / pirated / login-gated content
  • Credentialed providers are opt-in and inert by default

Security-sensitive?

This changes the company values selected for existing outbound people-search queries. The feature remains opt-in with the same query budget. Credentials, auth/tenancy, URL guards and provider transport are unchanged. No vulnerability disclosure is included.

Notes

AI-assisted implementation and tests; independently reviewed reproduction and patch. No schema, public API, dependencies or CI changes. The search seam is stubbed; no live external result is claimed.

All four unchanged canonical jobs passed on exact signed candidate 9aafa34: 2,098 SQLite tests (134 existing skips), 18 PostgreSQL tests, 63 frontend tests and three mounted Chromium regressions. Root independently reran all 62 focused tests. Upstream checks start separately after publication.

Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant