Repository navigation
fix(workbook): order mapped outputs after their source columns - #73
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
6 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A configured output column can appear before the formula/enrichment column it reads. Dependency discovery currently sees only
{placeholder}strings in destination config values, so bare source keys infield_mapand a Sheetscolumnslist are absent from the graph. The production runner consequently sends blank or stale values. A partial run with a missing producer, or a failed producer with an old result, can also dispatch.Change
Include explicitly configured source keys for Airtable, CRM, Instantly and Smartlead mappings, plus configured Sheets column lists, in existing dependency discovery. Instantly/Smartlead template keys use their actual placeholder semantics. Existing ordering, failed/missing upstream, cycle, batching and reactive guards now see these reads. Vendor field labels are not raw column references. Implicit adapter defaults remain unchanged.
Review attention: this affects outbound dispatch sequencing. Credentials, tenant scoping, network transports and URL guards are unchanged.
Verification
Exact final regression file on original main: 10 fail / 3 pass. Actual workbook runner, ORM and formula execution show Airtable/Sheets receiving empty or stale payloads.
After patch: 90 focused and adjacent tests pass. Controls cover existing-value partial runs, missing/failed producers, cycles, reactive dependencies, unchanged webhook templates and unrelated destination labels.
External Airtable/Sheets adapter calls are recorded offline; these fixtures do not prove delivery to a real remote service.
Local full backend attempt stops during collection because the retained runtime lacks
opentelemetry-instrumentation-fastapi. The unchanged canonical workflow then passed all four jobs on exact signed candidate0ff909f: frozen SQLite backend, PostgreSQL integrity/tenancy, frontend lint/tests/build and mounted React Chromium regressions. Owned validation run. This does not imply upstream checks have completed.Independently reviewed and reproduced with AI assistance; root reran all 90 focused tests.