Repository navigation
fix(workbook): persist terminal cell results before returning - #72
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
False conditions and missing AI/research prompts produce terminal cell results, but return before committing their ORM changes. The worker then closes its session, rolling the changes back. Old COMPLETE values can remain hydrated, or a newly attempted cell can have no persisted receipt.
Commit the existing terminal receipt and row state after the existing run fence, before these three returns. The skipped-cell broadcast follows the commit. Condition evaluation, terminal statuses and output run-once behavior are preserved.
Verification
84735689b1af0e7911a293ae20a8c8d996920813: backend SQLite 2,105 passed/134 skipped/3 deselected; PostgreSQL integrity and tenancy 18 passed; frontend lint/build and 63 Bun tests passed; mounted browser regressions 3 passed.Boundaries
Authentication, tenancy and provider authorization are unchanged. Local native evidence covers the SQLite worker and run fence, without HTTP authentication or provider/model/network calls. The existing hosted suite separately includes PostgreSQL integrity and tenancy checks.
Checklist