Repository navigation
fix(workbook): honor AND precedence in mixed conditions - #70
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Mixed workbook conditions currently split on AND before OR. For example,
{a} == "yes" OR {b} == "yes" AND {c} == "yes"can skip a column even when the first comparison is true.Evaluate OR groups of AND terms, using the existing quoted-aware tokenizer and comparison evaluator. This matches ordinary boolean precedence and the automation condition parser. Parenthesized expressions are not added.
Type
Verification
_run_one_cellenrichment against migrated SQLite: main 2 failed / 2 controls passed; this branch 4 passed. Both previously skipped mixed conditions now execute the formula and persist its value. No provider or network call.717f6697b79f82a89ba14a684846a6cb24d6ef90: fork verification. Upstream checks will run separately.Checklist
Security-sensitive?
This changes boolean grouping in the workbook condition evaluator. It does not change auth, tenancy, outbound fetches, credentials, or LLM handling.