Skip to content

fix(workbook): preserve falsey saved view comparison values - #61

Merged
debpalash merged 1 commit into
debpalash:mainfrom
rudycelekli:fix/workbook-falsey-view-values-20261006
Oct 7, 2026
Merged

debpalash merged 1 commit into
debpalash:mainfrom
rudycelekli:fix/workbook-falsey-view-values-20261006

Conversation

@rudycelekli

Copy link
Copy Markdown
Contributor

Summary

Saved view comparisons currently convert 0 and false into an empty string. A persisted zero-score or false-result filter can therefore select a blank row instead of its matching row, and CSV export repeats the same wrong scope.

Use an explicit null fallback when normalizing the comparison value, matching the client’s existing String(value ?? "") behavior. List and export continue to share the same query.

Validation

  • Native FastAPI/SQLite before: two persisted-view regressions fail, each returning the blank row instead of the matching row.
  • After: 214 workbook tests passed, including numeric zero, canonical formula "false" results, string controls, all four comparison operators, and unchanged null/empty comparisons; CSV contents are checked as well.
  • Frozen offline backend suite: 1,896 passed, 131 skipped, 3 deselected, with two unchanged warnings.
  • PostgreSQL integrity and full frontend hosted gates are pending. No live provider or paid calls.

This changes comparison normalization only. Boolean controls use the existing formula result representation ("false"); raw JSON boolean column rendering is unchanged.

Prepared with AI assistance; source and native regression evidence were reviewed before submission. Signed-off commits included.

Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
@rudycelekli
rudycelekli requested a review from debpalash as a code owner October 6, 2026 15:54
@debpalash
debpalash merged commit 89813d2 into debpalash:main Oct 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants