Optimise text_format:escape_label_value #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
conflict :-( |
gomoripeti
force-pushed
the
escape_label_opt
branch
from
6a34cea to
f1a3ffc
Compare
|
rebased to resolve the conflict |
ikavgo
approved these changes
Nov 17, 2023
ikavgo
approved these changes
Nov 17, 2023
|
Merging is blocked |
|
o wow, I have to "Learn more about singing commits" and get back to you |
Don't create a new binary if there is no special character to escape.
gomoripeti
force-pushed
the
escape_label_opt
branch
from
f1a3ffc to
0111151
Compare
|
pushed a signed commit now |
|
Great! Thank you |
|
would you mind tagging a new version including this change, so it can be included in RabbitMQ (used by this PR rabbitmq/rabbitmq-server#9656) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't create a new binary if there is no special character to escape.
This PR is based on #158 to preserve attribution of the author of that change.