Merge pull request Homebrew#16539 from dduugg/fixed-fixmes

Remove some fixed FIXMEs
dduugg · Jan 27, 2024 · 8392f70 · 8392f70
2 parents e55c14e + 8c832e0
commit 8392f70
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/Library/Homebrew/extend/pathname.rb b/Library/Homebrew/extend/pathname.rb
@@ -471,8 +471,7 @@ def magic_number
     else
       # Length of the longest regex (currently Tar).
       max_magic_number_length = 262
-      # FIXME: The `T.let` is a workaround until we have https://github.com/sorbet/sorbet/pull/6865
-      T.let(binread(max_magic_number_length), T.nilable(String)) || ""
+      binread(max_magic_number_length) || ""
     end
   end
 

diff --git a/Library/Homebrew/rubocops/cask/mixin/cask_help.rb b/Library/Homebrew/rubocops/cask/mixin/cask_help.rb
@@ -14,13 +14,6 @@ def on_cask(cask_block); end
         sig { overridable.params(cask_stanza_block: RuboCop::Cask::AST::StanzaBlock).void }
         def on_cask_stanza_block(cask_stanza_block); end
 
-        # FIXME: Workaround until https://github.com/rubocop/rubocop/pull/11858 is released.
-        def find_end_line(node)
-          return node.loc.end.line if node.block_type? || node.numblock_type?
-
-          super
-        end
-
         sig { params(block_node: RuboCop::AST::BlockNode).void }
         def on_block(block_node)
           super if defined? super