Fix objdir#31
Open
Jarod42 wants to merge 1 commit into
Open
Conversation
…bjdir` is correct in `qt.getGeneratedDir`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, you use
cfg.objdirbefore it is baked. (so you get"obj"instead of"obj/Release"and whennilyou don't use the same algo than premake-core neither).Currently, as default (i.e no
qtgenerateddirprovided), generated files are in same directory for all configs(and according to you :) :
So with that PR, we call
qt.customAddFileConfigafteroven.bakeObjDirs, socfg.objdiris correct inqt.getGeneratedDir.Note:
That currently breaks some generators (xcode4, Code::Blocks, Codelite) for default:
C::B doesn't handle different rule by configuration.
Similarly for xcode4, but I don't know if the limitation come from xcode4 or if it is a premake-core issue.
premake-core has issue with Codelite which generate a nil deferencement (which happen also before for some config)
Specifying appropriate
qtgenerateddiravoids that issue in that case.