Skip to content

Fix objdir#31

Open
Jarod42 wants to merge 1 commit into
dcourtois:masterfrom
Jarod42:fix_objdir
Open

Fix objdir#31
Jarod42 wants to merge 1 commit into
dcourtois:masterfrom
Jarod42:fix_objdir

Conversation

@Jarod42
Copy link
Copy Markdown
Contributor

@Jarod42 Jarod42 commented May 20, 2023

Currently, you use cfg.objdir before it is baked. (so you get "obj" instead of "obj/Release" and when nil you don't use the same algo than premake-core neither).

Currently, as default (i.e no qtgenerateddir provided), generated files are in same directory for all configs
(and according to you :) :

outputing generated files into the same folder/same name (which IMO is a bad practice, but that's probably just a matter of taste :))
)

So with that PR, we call qt.customAddFileConfig after oven.bakeObjDirs, so cfg.objdir is correct in qt.getGeneratedDir.

Note:
That currently breaks some generators (xcode4, Code::Blocks, Codelite) for default:
C::B doesn't handle different rule by configuration.
Similarly for xcode4, but I don't know if the limitation come from xcode4 or if it is a premake-core issue.
premake-core has issue with Codelite which generate a nil deferencement (which happen also before for some config)

Specifying appropriate qtgenerateddir avoids that issue in that case.

…bjdir` is correct in `qt.getGeneratedDir`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant