-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: overhaul skill discovery and authorized workflows #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
parsakhaz
wants to merge
2
commits into
main
Choose a base branch
from
codex/streamline-agent-workflows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Working on Skills | ||
|
|
||
| `parsa/` contains the active Claude, Codex, business, and SEO workflows. | ||
| `tyler/` is a frozen ancestor; Orchestra's canonical source is dcouple/orchestra. | ||
| Edit active sources here, preserving harness-specific tools and invocation | ||
| metadata. Shared variants that are identical should remain identical. | ||
|
|
||
| ## Authoring and completion | ||
|
|
||
| Keep descriptions concise and discriminating. Put conditional detail in linked | ||
| references with a read condition. Preserve output formats, caller names, | ||
| explicit authorization boundaries, and the evidence that determines readiness. | ||
| Load only the affected skills, callers, and relevant supporting material. | ||
|
|
||
| For implementation requests, continue through scoped changes, checks, fixes, | ||
| and the requested PR. Local branches, worktrees, and disposable verification | ||
| fixtures are part of that work. Existing authorization persists across routine | ||
| stage boundaries; planning-only requests and explicit review pauses still stop | ||
| before implementation. Merge, release, deployment, production/destructive | ||
| changes, and external posting require their own matching authorization. | ||
|
|
||
| Validate changed metadata, local reference links, and install/sync behavior. | ||
| Run scripts only against disposable fixtures for this audit, not the user's | ||
| installed skills or consumer repositories. Reuse passing results while inputs | ||
| remain unchanged. Read back pushes and PR state before reporting success. | ||
|
|
||
| Keep `./tmp/` scratch and unrelated changes out of commits. Discover repository | ||
| commands and target environments instead of hardcoding a consumer's stack. | ||
| Do not use em dashes in new instructions or PR prose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,5 @@ | ||
| ## Rules | ||
| See @AGENTS.md for scope, authoring, validation, and authorization boundaries. | ||
|
|
||
| - **You must verify after every mutation.** After a merge, push, PR | ||
| creation, file move, or any operation that changes state: read the | ||
| actual result back. Never trust command output alone - check that the | ||
| change landed where you expected it to. | ||
|
|
||
| - **You must not solve discoverable problems.** If the agent can query it | ||
| at runtime (via MCP, the environment, or the repo), don't hardcode it. | ||
| Describe roles, boundaries, and rules - not configuration. | ||
|
|
||
| - **Less is more.** Every line should earn its place. If removing a line | ||
| wouldn't change behavior, remove it. Overspecification leads to | ||
| configuration ceremony, leads to brittleness. When things are brittle, | ||
| they break. | ||
|
|
||
| - **No feedback loops.** A step that mutates code after review invalidates | ||
| downstream work. The pipeline is linear. Refactoring and cold-read are | ||
| manual skills, never inline. | ||
|
|
||
| - **You must never use em dashes.** Use commas, periods, colons, or | ||
| parentheses instead. | ||
| Fixes after review invalidate affected downstream evidence. Final QA belongs | ||
| after the last reviewed code change. Refactoring and cold-read are requested | ||
| workflows, not automatic implementation gates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this reviewer runs in a repository whose gates are not TypeScript lint/typecheck, the new repository-derived policy conflicts with the unchanged output and rules below: lines 82-84 still require
typecheckandlint, and line 149 explicitly requires running both. The Codex mirror retains the same conflict at lines 81-83 and 123, so either reviewer can invent irrelevant commands or misreport the checks that actually ran. Update the downstream report fields and rules to enumerate the discovered checks.AGENTS.md reference: AGENTS.md:L27-L28
Useful? React with 👍 / 👎.