Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renderer tests launched Electron while exercising only mocked Chromium pages, and smoke helpers bypassed Playwright actionability. Main tests also silently replaced a production service import for every suite and asserted source spelling instead of architecture or behavior.
This PR serves Vite for mocked renderer tests, uses locator click/fill, deletes the duplicate health check and test-only daemon frame predicates, and injects the panel persistence/event dependency explicitly in the two suites that need it. Daemon import/event restrictions move into ESLint; the existing real sandboxed Electron smoke keeps testing channel routing. Vitest configuration now uses ESM, removing Vite's deprecated CJS API warning.
The comprehensive Knip gate keeps every category blocking. A separate production analysis command marks shipped entrypoints and excludes test fixtures, exposing test-facing exports for review; it is a diagnostic view, not a suppression or replacement of the current gate. The remaining report includes intentional test seams and audit helpers removed in sibling PRs, so it is not promoted to a zero-baseline CI gate in this change.
The watch contract fixture also handles socket errors when watch clients deliberately terminate after receiving their expected output. It tolerates only ECONNRESET, preserves action failures, and rethrows other socket errors after server and endpoint cleanup. Contract assertions, timeouts, and parity scenarios remain intact.
Closes #624
Closes #627
Closes #628
Closes #629
Closes #630
Closes #632
Closes #642
Validation:
listen EPERM; the existing OS/runtime wrapper CI matrix provides full parity verification.No dependencies, supply-chain settings, production build targets, authentication, or persistence formats change.