Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote commands were replayed after transient failures even when the host could already have applied them. That could repeat terminal input or create extra panes. The browser's fetch fallback also ignored valid SSE frames with CRLF line endings.
This change:
No dependencies, supply-chain controls, authentication headers, or event-stream reconnect policy change.
Validation completed locally:
pnpm lintpnpm typecheckpnpm build:main, including the sandboxed preload verifierpnpm build:frontend, including xterm and React Scan bundle verifiersCI passes on
75944df48f03974ce2b9b72f1401156f3a8d983c: Linux quality checks, full main/frontend unit suites, maintained browser smoke (including the new lifecycle regression), sandboxed Electron preload smoke, macOS/Windows main tests, and React Doctor.Closes #613
Closes #623
Closes #636