Fix native beta packaging and draft release publishing - #586
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native voice dictation exposed recording without the required iOS microphone purpose string or Android permissions. Add those declarations and use Pane’s existing launcher artwork for both native clients. The signed iOS beta now carries the permission description and production push entitlements.
Release publishing also queried the REST tag endpoint for a draft, which returns 404. Resolve drafts through
gh release viewbefore publishing, preserving manually written release notes. This reproduces the v2.4.98 failure and prevents future releases from stopping at the draft stage.Validation:
pnpm lintandpnpm typecheckpassed.bash scripts/test-publish-github-release.shpassed, including draft lookup, manual notes preservation, published-release behavior, and failed lookup without mutation.Follow-up to #584. The v2.4.99 tag remains unchanged. Its draft was recovered with the corrected script after all platform jobs passed; the rerun completed successfully, including checksums, npm, PyPI, and website notification.