Skip to content

Update templates.js #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nr59684 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update templates.js #435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sr/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1553,7 +1553,7 @@ class AlgorithmIdentification extends Template {

class TrackingIdentifier extends Template {
constructor(options) {
super(options);
super();
Copy link
Contributor

@wayfarer3130 wayfarer3130 Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't just this one, but every Template extension (5 of them) in this appears to be wrong. Can you go through them and update the others?

Copy link
Collaborator

@fedorov fedorov Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nr59684 do you plan to follow up on this PR?

We very much welcome your contribution!

if (options.uid === undefined) {
throw new Error("Option 'uid' is required for TrackingIdentifier.");
}
Expand Down