fix: 'require is not defined' on prod for walletconnect #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
force-pushed
the
fix-walletconnect
branch
from
22ea211 to
b8f265c
Compare
metafraction
approved these changes
Dec 3, 2021
apbendi
force-pushed
the
fix-walletconnect
branch
from
b8f265c to
87d3139
Compare
- @dgrants/[email protected] - @dgrants/[email protected] - @dgrants/[email protected] - @dgrants/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #555, see that issue for details
This is not yet tested since this issue only happens in production build. @phutchins do branches deploy to a staging env we can test this on before merging?