tests: Test to make sure partition and disk names match libparted #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Cool, the new test is working. It's running against F36 where the new parted hasn't gone stable yet, so it is reporting that it is missing the known flags. |
Owner
|
I like this change, but the unit tests have failed. |
dcantrell
requested changes
Oct 13, 2022
Owner
dcantrell
left a comment
dcantrell
left a comment
There was a problem hiding this comment.
I like this change, but the unit tests have failed.
In the past there have been problems with pyparted not including all of
the partition flags from libparted due to its use of enums in the
_LAST macros. These were not caught by the tests because they skipped
flags that had no attribute (a valid case when building against an older
parted).
This adds tests that include all known parted flags, and uses libparted
to decide which ones must be included. The test will return errors for
all flags that libparted reports that are not attributes of _ped
If libparted reports a flag that pyparted does not support it is not
a failure and will be reported as a skipped test:
skipped 'Unknown flag: linux-home'
bcl
force-pushed
the
master-known-flags
branch
from
c0df3a7 to
6ea817c
Compare
Contributor
Author
|
Rebased onto main, added no_automount to the test. Needs the semicolon fix from #111 for tests to pass. |
dcantrell
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past there have been problems with pyparted not including all of
the partition flags from libparted due to it's use of enums in the
_LAST macros. These were not caught by the tests because they skipped
flags that had no attribute (a valid case when building against an older
parted).
This adds tests that include all known parted flags, and uses libparted
to decide which ones must be included. The test will return errors for
all flags that libparted reports that are not attributes of _ped
If libparted reports a flag that pyparted does not support it is not
a failure and will be reported as a skipped test: