Skip to content

Fix comment style consistency #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcantrell merged 1 commit into from
Jan 24, 2025
Merged

Fix comment style consistency #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/pydevice.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,14 +256,16 @@ PyObject *_ped_Device_get(_ped_Device *self, void *closure)

if (!strcmp(member, "model")) {
if (self->model != NULL) {
// There's at least one case of a non-UTF-8 model in the wild where
// using PyUnicode_FromString would crash (model b"MMC H8G4a\x92"
// on Wyse 3040 thin clients).
//
// Using PyUnicode_FromFormat instead will convert the 0x92 byte to
// the replacement character.
//
// https://github.com/dcantrell/pyparted/issues/76
/*
* There's at least one case of a non-UTF-8 model in the wild where
* using PyUnicode_FromString would crash (model b"MMC H8G4a\x92"
* on Wyse 3040 thin clients).
*
* Using PyUnicode_FromFormat instead will convert the 0x92 byte to
* the replacement character.
*
* https://github.com/dcantrell/pyparted/issues/76
*/
return PyUnicode_FromFormat("%s", self->model);
} else {
return PyUnicode_FromString("");
Expand Down
Loading