add links to lifecycle pill #6845
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
website/docs/docs/introduction.md
Outdated
| @@ -5,9 +5,19 @@ pagination_next: null | |||
| pagination_prev: null | |||
| --- | |||
|
|
|||
There was a problem hiding this comment.
will have to remove these test lifecycle pills before pr is merged
| <div className={styles.header} onClick={handleToggleClick}> | ||
| <span className={`${styles.toggle} ${isOn ? styles.toggleDown : styles.toggleRight}`}></span> | ||
| | ||
| <span className={styles.headerText}> | ||
| {alt_header}<Lifecycle status={lifecycle} /> | ||
| {alt_header} | ||
| <span onClick={(e) => e.stopPropagation()}> |
There was a problem hiding this comment.
this stops the copy link propagation so that users can click the pill for the link or click on the icon to copy the url
There was a problem hiding this comment.
Hey @mirnawong1 this is looking good and seems to function as expected.
Just a quick question for my own curiosity.
What is the difference between Legacy and Deprecated? Just thinking in terms of a user I almost expected Legacy to be clickable and listed in the product lifecycle page .
hey @john-rock ! hm that's a good question! we have some features that are considered legacy but you can still use them if you want and the documentation isn't going anywhere -- so they're not entirely deprecated (e.g. configuring snapshots using sql config block is legacy since the new way to do it is via YAML config). whereas deprecated means its not supported and docs will be removed. i wonder if we should add 'legacy' to the product lifecycle doc? i'll raise that with the PM team! thanks for asking such a great question! |
Ah I see, thank you for the context on that! |
|
omg thank you so much @john-rock ! i really appreciate the quick review! i was a bit nervous about this one and thank you for validating! |
this pr adds appropriate links to the lifecycle pill and ux elements to make it a bit clearer that they're linkable.
it also centralized links using the lifecycle-url.js file and const so we can update links in one place shoudl we need to change them. this change will also apply to new and existing lifecycle pills so there aren't different UX experiences for users.
docs notion project
requested by @runleonarun and asana task for PR review requested
🚀 Deployment available! Here are the direct links to the updated files: