Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metrics key #6797

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Move metrics key #6797

merged 1 commit into from
Jan 20, 2025

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Jan 20, 2025

This pr moves the metrics so it's not nested under semantic_models. Raised by user in community slack https://getdbt.slack.com/archives/C02CCBBBR1D/p1737248111053329


🚀 Deployment available! Here are the direct links to the updated files:

This pr moves the metrics so it's not nested under semantic_models. Raised by user in community slack https://getdbt.slack.com/archives/C02CCBBBR1D/p1737248111053329
@mirnawong1 mirnawong1 requested a review from a team as a code owner January 20, 2025 07:14
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 20, 2025 7:18am

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address and removed content Improvements or additions to content labels Jan 20, 2025
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

I wasn't able to test this but I mirrored the updated example in the thread ("metrics should live separately from semantic_models, not within them") and approved this for you.

Kind Regards
Natalie

@mirnawong1 mirnawong1 merged commit 44ea673 into current Jan 20, 2025
12 checks passed
@mirnawong1 mirnawong1 deleted the mirnawong1-patch-43 branch January 20, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants