Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8836: Add version to fqn when version==0 #8915

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Fix #8836: Add version to fqn when version==0 #8915

merged 2 commits into from
Oct 26, 2023

Conversation

aranke
Copy link
Member

@aranke aranke commented Oct 26, 2023

resolves #8836

Problem

dbt ls --select something was failing with IndexError because we weren't adding version to fqn when version == 0.

Solution

Change check from if version to if version is not None to add version to fqn when version == 0.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@aranke aranke requested a review from a team as a code owner October 26, 2023 05:26
@aranke aranke requested a review from QMalcolm October 26, 2023 05:26
@cla-bot cla-bot bot added the cla:yes label Oct 26, 2023
@aranke aranke requested review from MichelleArk and removed request for QMalcolm October 26, 2023 05:26
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6aeebc4) 86.31% compared to head (b707f81) 86.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8915      +/-   ##
==========================================
+ Coverage   86.31%   86.32%   +0.01%     
==========================================
  Files         177      177              
  Lines       26385    26385              
==========================================
+ Hits        22775    22778       +3     
+ Misses       3610     3607       -3     
Flag Coverage Δ
integration 83.11% <100.00%> (+0.01%) ⬆️
unit 64.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/contracts/graph/node_args.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants