Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualize Macros #8899

Closed
wants to merge 13 commits into from
Closed

Virtualize Macros #8899

wants to merge 13 commits into from

Conversation

peterallenwebb
Copy link
Contributor

resolves #8898

Problem

Slow.

Solution

Fast.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Oct 25, 2023
@peterallenwebb peterallenwebb changed the title Paw/virtualize macros Virtualize Macros Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (98310b6) 86.36% compared to head (485148e) 86.34%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8899      +/-   ##
==========================================
- Coverage   86.36%   86.34%   -0.02%     
==========================================
  Files         177      178       +1     
  Lines       26385    26350      -35     
==========================================
- Hits        22787    22752      -35     
  Misses       3598     3598              
Flag Coverage Δ
integration 82.99% <95.48%> (-0.22%) ⬇️
unit 64.63% <94.19%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/clients/jinja.py 89.40% <100.00%> (+0.54%) ⬆️
core/dbt/context/macro_resolver.py 99.07% <ø> (ø)
core/dbt/context/macros.py 90.36% <100.00%> (-9.64%) ⬇️
core/dbt/context/manifest.py 100.00% <100.00%> (ø)
core/dbt/context/providers.py 88.81% <100.00%> (ø)
core/dbt/parser/manifest.py 92.44% <100.00%> (+0.15%) ⬆️
core/dbt/parser/models.py 92.00% <100.00%> (+2.03%) ⬆️
core/dbt/utils.py 81.11% <100.00%> (ø)
core/dbt/context/virtual_macros.py 95.12% <95.12%> (ø)
core/dbt/contracts/graph/manifest.py 90.85% <95.55%> (+0.48%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@peterallenwebb peterallenwebb deleted the paw/virtualize-macros branch May 16, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3262] Explore the Performance Benefits of "Just in Time Macros"
3 participants