Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: partial parsing - reparse downstream nodes when adding versioning #11184

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

d-cole
Copy link

@d-cole d-cole commented Jan 2, 2025

Resolves # #8872

Problem

Adding versioning to a model with dependencies requires a full-parse. See workaround.

Solution

Schedule referencing nodes for parsing if the model in the new schema file is versioned (here).

Reviewer Questions

  • For this work and similar PRs, should unit and functional tests be added? Based on, "functional tests (tests/functional) cover anything that interacts with a database, namely adapter"", I initially planned on only adding unit tests. However, after seeing the existing tests in tests/functional/partial_parsing it seemed appropriate to add a functional test as well.
  • Type annotations were added to delete_schema_mssa_links but I ignored hints on the assignments to avoid including a larger refactor in this PR. Is there a preference for how type changes like this are handled? I see a mix of blanket ignores and type specific ignores (e.g. # type: ignore[assignment]).

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Jan 2, 2025
@d-cole d-cole changed the title Partial new version Partial parsing - reparse referencing nodes when adding versioning Jan 2, 2025
@d-cole d-cole changed the title Partial parsing - reparse referencing nodes when adding versioning fix: partial parsing - reparse downstream nodes when adding versioning Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant