Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the pytest timeout from 10min to 15min for python tests #1433

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

One of the python model tests takes just over 10 minutes to complete when run locally. However, we specify a timeout of 10 minutes in tox.ini.

Solution

Bump the timeout from 10 minutes to 15 minutes to allow the test to complete. This doesn't appear to be an issue in newer versions of dbt-bigquery, so it's not necessary to apply this change to newer versions.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Dec 12, 2024
@cla-bot cla-bot bot added the cla:yes label Dec 12, 2024
@mikealfare mikealfare added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Dec 12, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@mikealfare mikealfare merged commit d67590a into 1.7.latest Dec 12, 2024
31 of 33 checks passed
@mikealfare mikealfare deleted the bug/1.7.latest/list-inference branch December 12, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants