Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Job URL at Info Log Level #1429

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thatInfrastructureGuy
Copy link

@thatInfrastructureGuy thatInfrastructureGuy commented Dec 11, 2024

Original Discussion at https://github.com/dbt-labs/dbt-bigquery/pull/697/files#r1212630246

Job URL is super useful even beyond debugging code, since it's the ground truth of what logic and process is actually executing the model

resolves #696

Problem

BigQuery Job URL is hidden in debug logs. This makes it difficult to debug.

Solution

Display Job URL as part of Info logs

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@thatInfrastructureGuy thatInfrastructureGuy requested a review from a team as a code owner December 11, 2024 02:01
@cla-bot cla-bot bot added the cla:yes label Dec 11, 2024
Original Discussion at https://github.com/dbt-labs/dbt-bigquery/pull/697/files#r1212630246

> Job URL is super useful even beyond debugging code, since it's the ground truth of what logic and process is actually executing the model

Signed-off-by: thatInfrastructureGuy <[email protected]>
@thatInfrastructureGuy
Copy link
Author

@github-christophe-oudar
Copy link
Contributor

LGTM, I personally would like to see that log evolve to show what's the actual model being processed as I often have a lot of models running concurrently and I kind of struggle to find the one I want (but it's probably out of scope of that change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-513] [Feature] Move the BQ Job link after the job submission instead of job done
2 participants