fix(go): resolve pre-existing lint, staticcheck, and RAT debt - #7
Open
will-sargent-dbtlabs wants to merge 1 commit into
Open
fix(go): resolve pre-existing lint, staticcheck, and RAT debt#7will-sargent-dbtlabs wants to merge 1 commit into
will-sargent-dbtlabs wants to merge 1 commit into
Conversation
- errcheck: explicitly discard errors on 9 deferred Close() calls (file, gRPC clients, response bodies, GCS readers). - staticcheck SA4006: stop discarding the op.Wait result in executeCreateNotebookExecutionJob before it's immediately overwritten by the polling loop. - staticcheck SA1029: give ContextKeyUseStorageApiDisabledClient its own contextKey type instead of using a bare string as a context key. - staticcheck ST1023/QF1011 + intrange: drop the redundant oauth2.TokenSource type annotation and modernize the row iterator's counting loop to range-over-int (go fix's suggestions). - rat: add the missing ADBC Drivers Contributors license header to PORT_REVIEW.md. Verified locally: golangci-lint, go build/vet/test, codespell, go fix, and the Apache RAT check all pass clean.
will-sargent-dbtlabs
had a problem deploying
to
BigQuery CI
August 5, 2026 02:34 — with 
GitHub Actions
Failure
GitHub Actions
Failure
will-sargent-dbtlabs
had a problem deploying
to
BigQuery CI
August 5, 2026 02:34 — with
GitHub Actions
Failure
GitHub Actions
Failure
will-sargent-dbtlabs
had a problem deploying
to
BigQuery CI
August 5, 2026 02:34 — with
GitHub Actions
Error
GitHub Actions
Error
will-sargent-dbtlabs
had a problem deploying
to
BigQuery CI
August 5, 2026 02:34 — with
GitHub Actions
Error
GitHub Actions
Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Baseline repo-health cleanup for
main, split out from an unrelated PR (#6) since this is a separate failure domain from the GCP auth/CI issue also being tracked (see follow-up).Close()calls (file handle, Dataproc/notebook gRPC clients, HTTP response body, GCS reader/client) — matches the existing pattern used elsewhere in this package for calls where propagating the close error would require restructuring the function.executeCreateNotebookExecutionJobdiscardedop.Wait's return value before the polling loop immediately overwrote it — made that explicit.ContextKeyUseStorageApiDisabledClientnow has its owncontextKeytype instead of colliding with plainstringcontext keys.oauth2.TokenSourcetype annotation and modernized the row iterator's counting loop to range-over-int — both arego fix's own suggestions.PORT_REVIEW.md(it wasn't in.rat-excludesand every other doc file in the repo carries this header).No behavior changes — purely lint/staticcheck/license compliance.
Test plan
go build ./...go vet ./...go test ./...golangci-lint run— 0 issues (was 15)pre-commit run --all-fileson changed files — all hooks pass, includingrat