Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates to system declaration #715

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Conversation

netsettler
Copy link
Contributor

@netsettler netsettler commented May 2, 2023

The cgap-portal was not building properly on master. This fixes that and makes various small cosmetic changes.

  • In Makefile:
    • Use poetry 1.4.2 to get around libraries that were not loadable.
    • Move kill target to a different place to better align with snovault, which has such service operations nearer the end.
    • Request SQLAlchemy 2.0 warnings in testing.
  • In Dockerfile:
    • Also use poetry 1.4.2.
  • In pyproject.toml:
    • Update classifier and make various version requests align with what poetry solving was doing anyway. Should speed up locking.
    • Remove declared dependency on library py which probably only existed because pytest used to be py.test long ago. We don't still call it that.
    • Remove declared dependency on h5py, which we pinned only because it was giving us some problems. granite-suite 0.1.11b0 will pull it in anyway.
    • Move loremipsum dependency to dev dependencies, since it's not used at runtime.
    • Insert dependencies on matplotlib and pysam to match what's in Makefile for MacOS arm64 builds.
  • In src/encoded/tests/test_auth0.py:
    • Mark the test_jwt_is_stateless_so_doesnt_actually_need_login as xfail until we figure out why it's broken.
  • In src/encoded/tests/conftest.py:
    • Update a comment that refers to pytest as py.test to use the more modern spelling. No functional effect, but this was the only reference to the py library I could find by searching for regexp
     (^[ ]*(import|from)[ ]py[. ]|\bpy[.])
    

@netsettler
Copy link
Contributor Author

The current commit on GitHub is f0272de but I've done additional work I'm about to push. (I wanted to checkpoint where we were before that push in case an issue results.)

@netsettler
Copy link
Contributor Author

After that push, the current commit is: 0152d0c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants