Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply differently to questions than to statements. #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reply differently to questions than to statements. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dazeus-oracle.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
my ($self, $network, $sender, $channel, $command, $arg) = @_;
if (!defined($arg) || $arg eq "") {
reply("You'll have to give the oracle something to work with, " . $sender . ".", $network, $sender, $channel);
} elsif ($arg =~ m/\?$/) {
reply(oracle($arg) . "% yes.", $network, $sender, $channel);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too keen on the string in question. I'd prefer a full sentence, like the other reply.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I grepped for }oracle in my irc logs, and it's actually pretty hard to come up with some sentence that fits all questions. (But That is X% true almost never fits if it was a question.)

Any ideas?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I was never too bothered by the oracle's reply to questions. Perhaps we could just use 'likely' instead of 'true' for questions?

Suggested change
reply(oracle($arg) . "% yes.", $network, $sender, $channel);
reply("That is " . oracle($arg) . "% likely.", $network, $sender, $channel);

} else {
reply("That is " . oracle($arg) . "% true.", $network, $sender, $channel);
}
Expand Down