Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: agent support for windows #1741

Merged
merged 14 commits into from
Feb 7, 2025
Merged

Conversation

Rutik7066
Copy link
Contributor

Support for Daytona agent for windows

Description

This PR adds windows system call and conPTY for SSH

Contributor @unsuman & @Rutik7066

unsuman and others added 2 commits January 9, 2025 15:16
Signed-off-by: Rutik7066 <[email protected]>
@Rutik7066 Rutik7066 requested a review from a team as a code owner January 23, 2025 10:11
@idagelic
Copy link
Member

@Rutik7066 Please resolve the checks

Signed-off-by: Rutik7066 <[email protected]>
@Rutik7066
Copy link
Contributor Author

@idagelic Please check. added the fixes.

pkg/agent/agent.go Outdated Show resolved Hide resolved
Signed-off-by: Rutik7066 <[email protected]>
@Rutik7066 Rutik7066 requested a review from Tpuljak January 31, 2025 14:09
@Rutik7066
Copy link
Contributor Author

Rutik7066 commented Feb 1, 2025

@Tpuljak Please take a look remaining part of Windows Provider is completed

Screencast.from.2025-02-01.11-22-46.webm

Signed-off-by: Rutik7066 <[email protected]>
@Rutik7066 Rutik7066 changed the title Support for Daytona agent for windows feat: windows support for agent Feb 5, 2025
@Rutik7066 Rutik7066 changed the title feat: windows support for agent feat: agent support for windows Feb 5, 2025
pkg/ide/vscode.go Outdated Show resolved Hide resolved
Signed-off-by: Rutik Thakre <[email protected]>
@Rutik7066 Rutik7066 requested a review from Tpuljak February 7, 2025 17:56
pkg/ide/vscode.go Show resolved Hide resolved
@Tpuljak
Copy link
Member

Tpuljak commented Feb 7, 2025

@Rutik7066 please fix the failing PR check

Signed-off-by: Rutik Thakre <[email protected]>
@Rutik7066
Copy link
Contributor Author

@Tpuljak Done

@Tpuljak Tpuljak merged commit dfb50e8 into daytonaio:main Feb 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants