telemetry: track command errors #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- command errors are now properly tracked - fixed tracking of user-interruped commands - this change required refactoring CLI commands to return errors instead of throwing fatal errors Signed-off-by: Toma Puljak <[email protected]>
Tpuljak
force-pushed
the
telemetry-handle-cmd-errors
branch
from
7981059 to
cbdee81
Compare
lbrecic
approved these changes
Sep 26, 2024
idagelic
requested changes
Sep 27, 2024
Signed-off-by: Toma Puljak <[email protected]>
Signed-off-by: Toma Puljak <[email protected]>
idagelic
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telemetry: Track Command Errors
Description
This PR adds proper tracking of CLI commands that ended with an error. To do this, all the commands needed to be refactored to return errors instead of throwing fatals. Additionally, fixed the tracking of user-interrupted commands (e.g. ctrl+c out of the workspace creation process)