-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: commit signing using ssh and gpg #1146
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
@bryans-go from what I can see, you don't pass the properties from |
0660fde
to
25fea9e
Compare
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
Could you let us know which providers don't show the verified badge but should? P.S. Nice work on the solution! |
This comment was marked as abuse.
This comment was marked as abuse.
Then let's not show that input at all if the user selects Bitbucket or Gitness |
This comment was marked as abuse.
This comment was marked as abuse.
2c39a47
to
63060a3
Compare
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
@bryans-go please try to do some debugging yourself. Not completely sure but this might be part of the issue. The signing method is a string when passed here when it should be a pointer to a string. |
This comment was marked as abuse.
This comment was marked as abuse.
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
This comment was marked as abuse.
This comment was marked as abuse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Everything works except the one comment I left below.
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
This comment was marked as abuse.
This comment was marked as abuse.
Signed-off-by: bryans-go <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more comment to resolve before I can approve
Signed-off-by: bryans-go <[email protected]>
feat: commit signing using ssh and gpg
Description
add support for commit signing when adding git provider(s)
Related Issue(s)
Closes #370
/claim #370
Screenshots
Notes
In order to sign your commits with ssh . ssh keys need to be present on your local system and should be added to your github or gitlab account. my pr simplifies the work for manually doing setup for ssh commit signing in the gitconfig file of the project.
for the ssh key field : paste the same key that you pasted in the
add ssh key
in github or gitlab