Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken code of conduct link #1145

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

iamatinad
Copy link
Contributor

@iamatinad iamatinad commented Sep 24, 2024

Pull Request Title

Fixed broken Code of Conduct link

Description

This pull request addresses the issue of a broken link in the repository’s documentation. The previous link to the Code of Conduct resulted in a 404 Page Not Found error.

Motivation and Context:
The Code of Conduct is an important document that outlines the expected behavior of contributors. Ensuring that this link works correctly is essential for maintaining a welcoming and informative environment for all contributors.

##Dependencies:
No additional dependencies are required for this change.

  • This change requires a documentation update
  • [✅ ] I have made corresponding changes to the documentation

Related Issue(s)

Closes #1143

@iamatinad iamatinad requested a review from a team as a code owner September 24, 2024 16:19
@iamatinad iamatinad force-pushed the fix-broken-code-of-conduct-link branch from c888721 to 957395c Compare September 24, 2024 17:21
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and nice catch on the issue!

@Tpuljak
Copy link
Member

Tpuljak commented Sep 25, 2024

@iamatinad before final approval, please make sure to include the chore: subject in your commit. We follow conventional commits which you can read about here.

Also, instead of This PR addresses issue please use Closes so the issue gets closed automatically.

@iamatinad iamatinad force-pushed the fix-broken-code-of-conduct-link branch from 957395c to 7ca4626 Compare September 25, 2024 08:54
@iamatinad iamatinad force-pushed the fix-broken-code-of-conduct-link branch from 7ca4626 to 9786d53 Compare September 25, 2024 08:59
@iamatinad iamatinad changed the title Fixed broken Code of Conduct link fix: broken code of conduct link Sep 25, 2024
@iamatinad
Copy link
Contributor Author

iamatinad commented Sep 25, 2024

@iamatinad before final approval, please make sure to include the chore: subject in your commit. We follow conventional commits which you can read about here.

Also, instead of This PR addresses issue please use Closes so the issue gets closed automatically.

@Tpuljak Please I have made the necessary changes. Thank you

@iamatinad
Copy link
Contributor Author

Nice work and nice catch on the issue!

@Tpuljak Thank you so much.

@Tpuljak
Copy link
Member

Tpuljak commented Sep 25, 2024

@iamatinad before final approval, please make sure to include the chore: subject in your commit. We follow conventional commits which you can read about here.
Also, instead of This PR addresses issue please use Closes so the issue gets closed automatically.

@Tpuljak Please I have made the necessary changes. Thank you

Thanks, I just updated the description again to Closes #1143 .

@iamatinad
Copy link
Contributor Author

@iamatinad before final approval, please make sure to include the chore: subject in your commit. We follow conventional commits which you can read about here.
Also, instead of This PR addresses issue please use Closes so the issue gets closed automatically.

@Tpuljak Please I have made the necessary changes. Thank you

Thanks, I just updated the description again to Closes #1143 .

Well noted please I was supposed to use just Closes #1143 .

@lbrecic lbrecic merged commit 19e8079 into daytonaio:main Sep 25, 2024
12 checks passed
@iamatinad iamatinad deleted the fix-broken-code-of-conduct-link branch September 25, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code of Conduct Broken Link
3 participants