Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid path by renaming file #126

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

varshith257
Copy link
Contributor

@varshith257 varshith257 commented Dec 4, 2024

This PR resolves an issue caused by a file name in the repository containing an unsupported character (#). The file articles/20240828_Daytona_Office_Hours_#8:_Latest_Updates_and_Highlights.md was renamed to articles/20240828_Daytona_Office_Hours_8_Latest_Updates_and_Highlights.md to ensure compatibility with Windows and other filesystems.

@varshith257
Copy link
Contributor Author

@nkkko This needs to be merged ASAP as it is making trouble to clone the repository locally on Windows due to an invalid character
Please review and merge this fix to prevent further path-related issues

@mojafa
Copy link
Collaborator

mojafa commented Dec 7, 2024

@varshith257 what do you mean?
We have #9 as well. How is it affecting your PR?

@mojafa
Copy link
Collaborator

mojafa commented Dec 7, 2024

I had made an update to fix lint issues and compliance checks.

Please would again and make changes

@varshith257
Copy link
Contributor Author

@mojafa The issue is that I can't clone the repo due to invalid character name in a path for Windows. While receiving objects from upstream it getting terminate with error of unsupported character

@mojafa
Copy link
Collaborator

mojafa commented Dec 8, 2024

@nkkko Please look into this

@nkkko
Copy link
Member

nkkko commented Dec 13, 2024

tnx

@nkkko nkkko merged commit 176ab66 into daytonaio:main Dec 13, 2024
2 checks passed
@varshith257 varshith257 deleted the rename-file branch December 13, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants