Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Fly-Provider Docs #112

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Added Fly-Provider Docs #112

merged 4 commits into from
Nov 13, 2024

Conversation

scshiv29-dev
Copy link
Contributor

@scshiv29-dev scshiv29-dev commented Nov 7, 2024

/claim #79

Writer's Checklist

Writing Structure

  • Use short sentences and paragraphs, and include bucket brigades.
  • Include more than two descriptive H2 headings to organize content.
  • Capitalize headings according to the AP Stylebook (use this tool)
  • Include an introduction with at least two paragraphs before the first H2 section.
  • Use appropriate formatting (bold, italic, underline), notes, quotes, TLDRs, and key points.
  • Incorporate code elements and Markdown format where appropriate.
  • Ensure at least one visual element per “screen” of the article (screenshots, diagrams, tables, graphs, lists, sidenotes, blockquotes).

Fact-Checking

  • Verify all facts and data points included in the article.

Asset Management

  • Save images in the /assets folder.
  • Follow naming conventions: YYYYMMDD_title_of_the_article_IMG_NAME_NO.png.
  • (Optional) Create a GitHub repo for the code referenced in the article and share it.
  • (Optional) Include a link to this Loom video in the PR comments.

Interlinking

Glossary/Definitions

  • Create new definition in /defitnitions folder.

Review and Edit

  • Ensure articles address the needs of the target audience and their search intent.
  • Read the article out loud to catch any awkward phrasing.
  • Run the draft through Grammarly or a similar grammar tool.
  • Double-check adherence to the style guide and repository guidelines.
  • Use the name of the article for the title of the PR.

Signed-off-by: Shivam Deepak Chaudhary <[email protected]>
@scshiv29-dev scshiv29-dev mentioned this pull request Nov 7, 2024
11 tasks
@algora-pbc algora-pbc bot mentioned this pull request Nov 7, 2024
@mojafa mojafa assigned mojafa and unassigned mojafa Nov 11, 2024
Copy link
Collaborator

@mojafa mojafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versions are not marked alpha anymore. Review the version number and update.

Copy link
Collaborator

@mojafa mojafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test that creating your first workspace works. The command to create a workspace doesn't seem to be working. The flag --provider no longer works.

@mojafa
Copy link
Collaborator

mojafa commented Nov 11, 2024

@scshiv29-dev Daytona Provider Documentation, this link is no longer valid as well

@scshiv29-dev
Copy link
Contributor Author

versions are not marked alpha anymore. Review the version number and update.

image

When I do provider install I am still seeing alpha versions

@mojafa
Copy link
Collaborator

mojafa commented Nov 11, 2024

Screenshot 2024-11-11 at 16 34 02

@mojafa
Copy link
Collaborator

mojafa commented Nov 11, 2024

Please check your versions again, uninstall and reinstall

@scshiv29-dev
Copy link
Contributor Author

scshiv29-dev commented Nov 11, 2024

@mojafa I uninstalled and reinstalled again to the latest v0.44 yet it still is giving me alpha tags , also the script at docs needs update to point to new version.

I've update the article but the snips are still the same I am not able to get new versions .

image

image

Signed-off-by: Shivam Deepak Chaudhary <[email protected]>
@mojafa
Copy link
Collaborator

mojafa commented Nov 11, 2024

Screenshot 2024-11-11 at 19 17 26

@mojafa
Copy link
Collaborator

mojafa commented Nov 11, 2024

Hey please review the section: Creating Your First Workspace. The commands still don't work

@mojafa
Copy link
Collaborator

mojafa commented Nov 11, 2024

Equally, the command to list a workspace is daytona list not daytona workspace list

Signed-off-by: Shivam Deepak Chaudhary <[email protected]>
@mojafa
Copy link
Collaborator

mojafa commented Nov 11, 2024

@scshiv29-dev almost done, just remove the -t fly in these commands:

  1. From a Git Repository:
daytona create https://github.com/daytonaio/content --name workspacename -t fly
  1. With Custom Image:
daytona create  https://github.com/daytonaio/content  --custom-image ubuntu:latest --custom-image-user ubuntu --name workspacename -t fly

everything else works!

Signed-off-by: Shivam Deepak Chaudhary <[email protected]>
@scshiv29-dev
Copy link
Contributor Author

@mojafa I've made the reviewed changes .

Copy link
Collaborator

@mojafa mojafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR meets the requirements @nkkko

@nkkko nkkko merged commit f4efc47 into daytonaio:main Nov 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants