feat: allow @ in branch field for monorepo tag support#176
Open
GiffenGood1 wants to merge 1 commit intodavis7dotsh:mainfrom
Open
feat: allow @ in branch field for monorepo tag support#176GiffenGood1 wants to merge 1 commit intodavis7dotsh:mainfrom
GiffenGood1 wants to merge 1 commit intodavis7dotsh:mainfrom
Conversation
Enables monorepo-style git tags like @scope/pkg@version (e.g. @shopify/[email protected]) in the branch field. The @ character is safe since Bun.spawn uses array-based args and the existing refine rule still blocks branches starting with - (git option injection). Closes davis7dotsh#7, closes davis7dotsh#49 Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
couldn't find a way to get btca to work with monorepo-style git tags like
@chakra-ui/[email protected]Just a small update to allow them in the branch namesSummary
@to the branch name validation regex, enabling monorepo-style git tags like@chakra-ui/[email protected]in thebranchfield@symbolspatternto the JSON schemabranchfieldGreptile Overview
Greptile Summary
Added support for
@symbols in git branch names to enable monorepo-style tags like@chakra-ui/[email protected].Changes:
BRANCH_NAME_REGEXin bothschema.tsandvalidation/index.tsto include@in allowed characters@symbolsNo plan markdown files found in this PR.
Confidence Score: 5/5
@to allowed characters while preserving critical security validations (no leading hyphens, character restrictions). Comprehensive test coverage validates both the new functionality and rejection of dangerous patterns. No breaking changes to existing features.Important Files Changed
@symbols and updated error message to mention@symbols@symbols and updated error message in validateBranchName@symbols as allowed characters@symbols, rejection tests for invalid patterns(2/5) Greptile learns from your feedback when you react with thumbs up/down!