Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ⚡️ add catalog to website #31

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

DistributedDoge
Copy link
Collaborator

@DistributedDoge DistributedDoge commented Jan 6, 2024

EDIT: Working on #29, by making catalog notebook which can be re-run to extract schema from files in tables folder.

Updated preview => https://distributeddoge.github.io/gitcoin-grants-data-portal/catalog.html

  • make publish will now cause all notebook cells to re-run, before sending it to github pages.
  • there is technically a detailed sidebar TOC you can preview by setting toc-depth: 2 but then it covers dataframes when scrolling, so I think links are easier on the eyes.

Copy link
Owner

@davidgasquez davidgasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super quick review (haven't looked at the actual notebook code).

Not needed for this iteration but I was wondering if there is a way to use the sidebar (showing all the tables) to make navigation easier.

Awesome work again @DistributedDoge! This is going to make data discovery muuuuch better.

portal/catalog.ipynb Outdated Show resolved Hide resolved
portal/catalog.ipynb Outdated Show resolved Hide resolved
Copy link
Owner

@davidgasquez davidgasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks incredible @DistributedDoge!

Ready to merge or is there anythihng else lingering you want to add here?

@DistributedDoge
Copy link
Collaborator Author

Ready to merge, let's just inspect the portal later to see if it actually worked.

@davidgasquez davidgasquez merged commit 17b1b97 into davidgasquez:main Jan 6, 2024
1 check passed
@davidgasquez
Copy link
Owner

davidgasquez commented Jan 6, 2024

Seems the CI worked but the page is not there yet. 🔍

It should appear here: https://davidgasquez.github.io/gitcoin-grants-data-portal/catalog.html

@DistributedDoge
Copy link
Collaborator Author

DistributedDoge commented Jan 6, 2024

@davidgasquez that is because CI run does not update github pages.

Last update to github pages happened 2 weeks ago. I think one of your github-actions refactorings dropped that functionality from CI.

my workflow to update portal was to manually:

  • make run
  • make publish

@davidgasquez
Copy link
Owner

I think one of your github-actions refactorings dropped that functionality from CI.

Yep! Need to get that back. Didn't meant to drop it! Probably a great opportunity to push it to IPFS too (and even gitcoin-data.eth.limo)! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants