-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ⚡️ add catalog to website #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super quick review (haven't looked at the actual notebook code).
Not needed for this iteration but I was wondering if there is a way to use the sidebar
(showing all the tables) to make navigation easier.
Awesome work again @DistributedDoge! This is going to make data discovery muuuuch better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks incredible @DistributedDoge!
Ready to merge or is there anythihng else lingering you want to add here?
Ready to merge, let's just inspect the portal later to see if it actually worked. |
Seems the CI worked but the page is not there yet. 🔍 It should appear here: https://davidgasquez.github.io/gitcoin-grants-data-portal/catalog.html |
@davidgasquez that is because CI run does not update github pages. Last update to github pages happened 2 weeks ago. I think one of your github-actions refactorings dropped that functionality from CI. my workflow to update portal was to manually:
|
Yep! Need to get that back. Didn't meant to drop it! Probably a great opportunity to push it to IPFS too (and even |
EDIT: Working on #29, by making
catalog
notebook which can be re-run to extract schema from files intables
folder.Updated preview => https://distributeddoge.github.io/gitcoin-grants-data-portal/catalog.html
make publish
will now cause all notebook cells to re-run, before sending it to github pages.toc-depth: 2
but then it covers dataframes when scrolling, so I think links are easier on the eyes.