Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ELFFile#vma_from_offset helper and tests #76

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

Vasfed
Copy link
Contributor

@Vasfed Vasfed commented Mar 6, 2025

When parsing elf files it's usually useful to have vma_from_offset (inverse of offset_from_vma).

Also changed offset_from_vma to return nil instead of segments when address is not found, this seems to be more logical

Copy link
Owner

@david942j david942j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The change looks very clean and good. Only some minor suggestions.

@Vasfed Vasfed force-pushed the add_vma_from_offset branch from 45d356b to 88a59db Compare March 17, 2025 10:35
@david942j
Copy link
Owner

Merged, thanks!

@david942j david942j merged commit bf30c19 into david942j:master Mar 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants